Fix bits length of Shake 128 (16 not 32) & 256 (32 not 64)#44
Open
vorburger wants to merge 1 commit intomultiformats:mastermultiformats/java-multihash:masterfrom
Open
Fix bits length of Shake 128 (16 not 32) & 256 (32 not 64)#44vorburger wants to merge 1 commit intomultiformats:mastermultiformats/java-multihash:masterfrom
vorburger wants to merge 1 commit intomultiformats:mastermultiformats/java-multihash:masterfrom
Conversation
Contributor
|
These are extendable-output algorithms that can produce hashes of any length. As far as I understand, the outputs of SHAKE128 and SHAKE256 do indeed have just 16 and 32 bytes of entropy, but nothing prevents you from generating a SHAKE128 hash that's 1000 bytes long. That said, it looks like this library doesn't support hashes of variable length (see #45). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ianopolous @mk868 does this seem better to you as well? (Or am I just confused?)