fix for 0xc4 array length in unpacker #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on android I had problems with negative-size arrays, this fixes them
Member
|
I think it should throw SizeLimitException rather than faking the length because using wrong length may return broken value silently. |
Author
|
0xc4 is a bin8, which, according to spec stores a byte array whose length is upto (2^8)-1 bytes. Byte is signed, meaning that all values greater than 127 will be negative even when cast to int, so SizeLimitException in case of negative length is incorrect, that;s why I have introduced my change. |
Member
|
Oh, I see. You're right. I miss read the change. |
frsyuki
added a commit
that referenced
this pull request
Aug 12, 2014
fix for 0xc4 array length in unpacker
Member
|
I've merged. Thank you for the pull-req! |
Author
|
You are welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on android I had problems with negative-size arrays, this fixes them