test: fix error with npm8#592
Merged
DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom Feb 5, 2022
Merged
test: fix error with npm8#592DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom
DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom
Conversation
```
packageJson.optionalDependencies = { npm: '*' }
```
The reason seems to be that the contents of 'package.json' and 'package-lock.json' do not match according to the above.
Removing package-lock.json will not affect the validity of this test.
Contributor
Author
|
The windows test continues to fail for nodejs12 and 14. The other failures are timeout errors that have occurred before, so we will ignore them for now. |
DeviaVir
approved these changes
Feb 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason seems to be that the contents of 'package.json' and 'package-lock.json' do not match according to the above.
Removing 'package-lock.json' will not affect the validity of this test.