Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: support for 'ImageUri' parameter#548

Merged
DeviaVir merged 4 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
abetomo:feature/support_image_uriabetomo/node-lambda:feature/support_image_uriCopy head branch name to clipboard
Jan 26, 2021
Merged

feat: support for 'ImageUri' parameter#548
DeviaVir merged 4 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
abetomo:feature/support_image_uriabetomo/node-lambda:feature/support_image_uriCopy head branch name to clipboard

Conversation

@abetomo
Copy link
Contributor

@abetomo abetomo commented Jan 26, 2021

  • Upgraded to aws-sdk with ImageUri available.
  • ImageUri is now supported.
  • Push to ECR is not implemented.

This is not related to the main topic, but the files created by node-lambda setup have been added to .gitignore.

Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great

@DeviaVir DeviaVir merged commit 6d2bca4 into motdotla:master Jan 26, 2021
@abetomo abetomo deleted the feature/support_image_uri branch January 26, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.