Clean the tmp directory during _archivePrebuilt to match _buildAndArchive behavior#518
Merged
DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom Apr 24, 2021
Merged
Clean the tmp directory during _archivePrebuilt to match _buildAndArchive behavior#518DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom
DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom
Conversation
DeviaVir
approved these changes
Apr 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently noticed an issue where if
prebuiltDirectorywas set, the zip file generated bynode-lambda packagewould include files I had already deleted from my source. Turns out it was combining the output of the current run with the contents of earlier runs. The fix is to clean the_codeDirectory()before writing to it, which matches the existingnode-lambda packagebehavior whenprebuiltDirectoryis not set.Other than running the unit tests, I tested the changes in my project and verified that the temp directory is emptied between runs.