Add dockerVolumes option in package in order to mount additional volumes#473
Merged
DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom Nov 27, 2018
Merged
Add dockerVolumes option in package in order to mount additional volumes#473DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom
DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom
Conversation
26504d8 to
709b30c
Compare
DeviaVir
approved these changes
Nov 27, 2018
Collaborator
DeviaVir
left a comment
There was a problem hiding this comment.
LGTM, thanks for the addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again !
In some docker use cases it could be useful to be able to mount other volumes than the one with the sources of the lambda.
As an example, it will permit to mount credentials informations from an ssh directory. Also I think this will solve the issue talked in #379 cause it will be possible to mount a file with the aws credentials without adding all the other options.