Add keepNodeModules option in package#472
Merged
DeviaVir merged 2 commits intomotdotla:mastermotdotla/node-lambda:masterfrom Nov 27, 2018
Merged
Add keepNodeModules option in package#472DeviaVir merged 2 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
DeviaVir merged 2 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
Conversation
24e96c7 to
28e296d
Compare
DeviaVir
approved these changes
Nov 27, 2018
Collaborator
DeviaVir
left a comment
There was a problem hiding this comment.
I understand the usecase, and it's documented well. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Depending on your lambda dependencies,
npm installcould be really slow to execute.Furthermore, in the case of a docker build, these dependencies are installed each time we package our lambda (because of the codeDirectory which is cleaned and mounted in
/var/task).So I added the
keepNodeModulesoption in order to skip thenpm istep for cases where we don’t need to reinstall all the dependencies if we don’t add any new module.Also I put this option to false by default in order to not disturb the actual behaviour.
Thx again for this project !