Add class for uploading deploy package to S3#454
Merged
DeviaVir merged 2 commits intomotdotla:mastermotdotla/node-lambda:masterfrom Aug 2, 2018
abetomo:fix_s3_region_used_for_deployabetomo/node-lambda:fix_s3_region_used_for_deployCopy head branch name to clipboard
Merged
Add class for uploading deploy package to S3#454DeviaVir merged 2 commits intomotdotla:mastermotdotla/node-lambda:masterfrom abetomo:fix_s3_region_used_for_deployabetomo/node-lambda:fix_s3_region_used_for_deployCopy head branch name to clipboard
DeviaVir merged 2 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
abetomo:fix_s3_region_used_for_deployabetomo/node-lambda:fix_s3_region_used_for_deployCopy head branch name to clipboard
Conversation
DeviaVir
approved these changes
Aug 1, 2018
lib/s3_deploy.js
Outdated
| 'ap-northeast-1', | ||
| 'sa-east-1', | ||
| 'cn-north-1', | ||
| 'eu-central-1' |
Collaborator
There was a problem hiding this comment.
may want to order this list alphabetically
Contributor
Author
|
I sorted the region. |
teebu
added a commit
to teebu/node-lambda
that referenced
this pull request
Aug 6, 2018
This reverts commit 6500e23
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/main.jsto S3 when merged.