Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix using klaw instead of fs.walk#424

Merged
DeviaVir merged 2 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
abetomo:upgrade_fs_extraabetomo/node-lambda:upgrade_fs_extraCopy head branch name to clipboard
May 14, 2018
Merged

Fix using klaw instead of fs.walk#424
DeviaVir merged 2 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
abetomo:upgrade_fs_extraabetomo/node-lambda:upgrade_fs_extraCopy head branch name to clipboard

Conversation

@abetomo
Copy link
Contributor

@abetomo abetomo commented Apr 27, 2018

Since fs-extra we use is too old, I would like to upgrade it.
In the latest fs-extra, walk will be gone, so it's a fix using klaw.
https://github.com/jprichardson/node-fs-extra#what-happened-to-walk-and-walksync

Once this PR is merged, upgrade fs-extra.

@DeviaVir
Copy link
Collaborator

Do you want to PR the fs-extra upgrade?

@DeviaVir DeviaVir merged commit ea985ed into motdotla:master May 14, 2018
@abetomo
Copy link
Contributor Author

abetomo commented May 14, 2018

I planned to PR to upgrade fs-extra !

@abetomo abetomo deleted the upgrade_fs_extra branch May 14, 2018 08:28
@abetomo abetomo mentioned this pull request Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.