Remove env var value from commanderjs flag definitions#409
Merged
DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom Jan 12, 2018
MartinNuc:fix-commanderjs-flag-definitionsMartinNuc/node-lambda:fix-commanderjs-flag-definitionsCopy head branch name to clipboard
Merged
Remove env var value from commanderjs flag definitions#409DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom MartinNuc:fix-commanderjs-flag-definitionsMartinNuc/node-lambda:fix-commanderjs-flag-definitionsCopy head branch name to clipboard
DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom
MartinNuc:fix-commanderjs-flag-definitionsMartinNuc/node-lambda:fix-commanderjs-flag-definitionsCopy head branch name to clipboard
Conversation
Repository owner
deleted a comment
Jan 12, 2018
DeviaVir
approved these changes
Jan 12, 2018
Collaborator
|
I'll make sure to push a new tag soon including this fix. |
Contributor
Author
|
Thank you. I also tried to write a test for it but the only test I was able to write took 25s :( hopefully it will be fine like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #408
When
-no-is used in flag definition (which may get there for example when you name your functionheader-no-cache) it treats flag incorrectly and assignstrueas a value.