Add event_sources.json to setup message#402
Merged
DeviaVir merged 3 commits intomotdotla:mastermotdotla/node-lambda:masterfrom Dec 19, 2017
Merged
Add event_sources.json to setup message#402DeviaVir merged 3 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
DeviaVir merged 3 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
Conversation
It changed to display by using console format.
DeviaVir
reviewed
Dec 19, 2017
lib/main.js
Outdated
| 'Edit the .env, deploy.env, %s, event_sources.json and %s files as needed.', | ||
| program.contextFile, | ||
| program.eventFile | ||
| ) |
Collaborator
There was a problem hiding this comment.
might look nicer as:
console.log(`Setup done.
Edit the .env, deploy.env, ${program.contextFile}, event_sources.json and ${program.eventFile} as needed.`)
see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
Contributor
Author
There was a problem hiding this comment.
OK!
(Because the width was long, I tried to adopt format to do some line breaks.)
DeviaVir
approved these changes
Dec 19, 2017
abetomo
added a commit
to abetomo/node-lambda
that referenced
this pull request
Dec 20, 2017
Because we used template literals at motdotla#402, we unified.
DeviaVir
pushed a commit
that referenced
this pull request
Dec 20, 2017
Because we used template literals at #402, we unified.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It changed to display by using console format.