Added class to set S3 events#393
Merged
DeviaVir merged 4 commits intomotdotla:mastermotdotla/node-lambda:masterfrom Dec 7, 2017
Merged
Added class to set S3 events#393DeviaVir merged 4 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
DeviaVir merged 4 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
Conversation
abetomo
commented
Dec 7, 2017
| "test": "standard && standard bin/node-lambda && mocha" | ||
| "lint": "standard && standard bin/node-lambda", | ||
| "test": "npm run lint && npm run unit", | ||
| "unit": "mocha" |
Contributor
Author
There was a problem hiding this comment.
It has nothing to do with subject matter, but cleaned the scripts.
DeviaVir
approved these changes
Dec 7, 2017
Collaborator
DeviaVir
left a comment
There was a problem hiding this comment.
Just some language feedback, looks good to me 👍
lib/s3_events.js
Outdated
| 'use strict' | ||
|
|
||
| /** | ||
| * Do not create Bucket of S3 |
lib/s3_events.js
Outdated
| if (err) { | ||
| if (err.code !== 'ResourceConflictException') reject(err) | ||
| // If it exists it will result in an error but there is no problem. | ||
| resolve('Already exists permission') |
Contributor
Author
|
@DeviaVir Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added class to set s3 events.
In the next PR add S3Events to main.js.