Remove configFile Option of package command in README#350
Merged
DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom Jul 10, 2017
abetomo:update_readme_remove_configfile_option_in_packageabetomo/node-lambda:update_readme_remove_configfile_option_in_packageCopy head branch name to clipboard
Merged
Remove configFile Option of package command in README#350DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom abetomo:update_readme_remove_configfile_option_in_packageabetomo/node-lambda:update_readme_remove_configfile_option_in_packageCopy head branch name to clipboard
DeviaVir merged 1 commit intomotdotla:mastermotdotla/node-lambda:masterfrom
abetomo:update_readme_remove_configfile_option_in_packageabetomo/node-lambda:update_readme_remove_configfile_option_in_packageCopy head branch name to clipboard
Conversation
For the package command the configfile option is meaningless
Collaborator
|
no, I think this is better. |
Contributor
Author
|
Thanks for checking! When do you want to remove from the code? |
Collaborator
|
@abetomo I think you can already create the PR and we can merge it, I will simply wait a bit longer before cutting a new release then. |
Contributor
Author
|
I opened #351. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the package command the configfile option is meaningless.
I removed it in the README, but would it be better to write a note of deprecated?