Refactoring _archive#338
Merged
DeviaVir merged 7 commits intomotdotla:mastermotdotla/node-lambda:masterfrom Jun 28, 2017
abetomo:refactoring_archiveabetomo/node-lambda:refactoring_archiveCopy head branch name to clipboard
Merged
Refactoring _archive#338DeviaVir merged 7 commits intomotdotla:mastermotdotla/node-lambda:masterfrom abetomo:refactoring_archiveabetomo/node-lambda:refactoring_archiveCopy head branch name to clipboard
_archive#338DeviaVir merged 7 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
abetomo:refactoring_archiveabetomo/node-lambda:refactoring_archiveCopy head branch name to clipboard
Conversation
Modify that _readArchive returns Promise
Modify that _archivePrebuilt returns Promise
Modify that _archive returns Promise
The condition was reversed.
That is simpler
DeviaVir
approved these changes
Jun 28, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored the part related to the _archive function.