Added _updateEventSources test and refactoring#308
Merged
DeviaVir merged 9 commits intomotdotla:mastermotdotla/node-lambda:masterfrom Jun 6, 2017
Merged
Added _updateEventSources test and refactoring#308DeviaVir merged 9 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
_updateEventSources test and refactoring#308DeviaVir merged 9 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
Conversation
- Only variables that can be modified - It is the target declared in global
For use in other tests
DeviaVir
approved these changes
Jun 6, 2017
Collaborator
DeviaVir
left a comment
There was a problem hiding this comment.
👍 makes sense, tests pass.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to add a test for
Lambda.prototype.deploy(), but since it was difficult with the specifications of the current function, I will add a test for the function that is calling internally.(Preparation before modifying #300)