Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Refactoring and unnecessary package removal#307

Merged
DeviaVir merged 2 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
abetomo:refactor_schedule_eventsabetomo/node-lambda:refactor_schedule_eventsCopy head branch name to clipboard
Jun 4, 2017
Merged

Refactoring and unnecessary package removal#307
DeviaVir merged 2 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
abetomo:refactor_schedule_eventsabetomo/node-lambda:refactor_schedule_eventsCopy head branch name to clipboard

Conversation

@abetomo
Copy link
Contributor

@abetomo abetomo commented Jun 3, 2017

  • Remove unnecessary else (lib/schedule_events.js)
    • It is unnecessary because it is returning in the if statement
  • Remove unused package

abetomo added 2 commits May 30, 2017 18:37
It is unnecessary because it is returning in the if statement
Copy link
Collaborator

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch

@DeviaVir DeviaVir merged commit ada18aa into motdotla:master Jun 4, 2017
@abetomo abetomo deleted the refactor_schedule_events branch June 5, 2017 01:20
@DeviaVir DeviaVir mentioned this pull request Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.