Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Added - cwd option to npm install command#265

Merged
DeviaVir merged 3 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
abetomo:add_npm_install_cwd_optionabetomo/node-lambda:add_npm_install_cwd_optionCopy head branch name to clipboard
May 8, 2017
Merged

Added - cwd option to npm install command#265
DeviaVir merged 3 commits intomotdotla:mastermotdotla/node-lambda:masterfrom
abetomo:add_npm_install_cwd_optionabetomo/node-lambda:add_npm_install_cwd_optionCopy head branch name to clipboard

Conversation

@abetomo
Copy link
Contributor

@abetomo abetomo commented May 8, 2017

Because Refusing to install node - lambda as a dependency of itself
error occurs on Windows

===> In my Windows environment.
All unit test passes on Windows.
Also confirmed that setup, package, run, deploy worked. (Conducted only simple confirmation)

@DeviaVir DeviaVir merged commit 428a0ab into motdotla:master May 8, 2017
@DeviaVir
Copy link
Collaborator

DeviaVir commented May 8, 2017

I'm planning on baking a new release with all of your fixes so far. Any reason I should hold off?

@abetomo
Copy link
Contributor Author

abetomo commented May 8, 2017

Thank you.
The correction I was planning was completed. Therefore, it is OK to release!
(If there are any bugs after release, I will fix it soon.)

@abetomo abetomo deleted the add_npm_install_cwd_option branch May 8, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.