Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: Improve error handling if walk browser profile dir #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

moonD4rk
Copy link
Owner

@moonD4rk moonD4rk commented Jul 15, 2024

  • Implement error handling for path permission errors in chromiumWalkFunc
  • Refactor firefoxWalkFunc to handle permission errors and log warnings
  • Add import statement for log/slog in firefox/firefox.go

Proposed changes

If access to the browser configuration file is not permitted, print an error log and skip.

Close #345

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit, build tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

- Implement error handling for path permission errors in `chromiumWalkFunc`
- Refactor `firefoxWalkFunc` to handle permission errors and log warnings
- Add import statement for `log/slog` in `firefox/firefox.go`
@moonD4rk moonD4rk merged commit 8fa73d4 into dev Jul 15, 2024
6 checks passed
@moonD4rk moonD4rk deleted the fix/filewalk-permission branch July 16, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.