Fix regression that breaks projects using .NET Framework/Mono and packages.config #3112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2024
Contributor
Author
|
@mattleibow Could you please take a look? We are stuck with SkiaSharp 2.x until this NuGet issue is resolved. |
mattleibow
approved these changes
Feb 21, 2025
Contributor
|
/rebase |
Contributor
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
Author
|
The NuGet packages from the Azure artifacts look fine. The dll files have been copied properly for my old .NET Framework project. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Starting with SkiaSharp 3.x only the
buildTransitivedirectory is created for the NativeAssets NuGet packages. This breaks older .NET Framework projects that usepackages.configinstead of the newerPackageReference.To retain backwards compatibility this PR copies the
net462\SkiaSharp.NativeAssets.*.targetsfile into bothbuildandbuildTransitive(as it was for before in SkiaSharp 2.x).Bugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist