Fix actions #3
Merged
Fix actions #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using relative paths in a composite action does not import the action file from the action repository, but from the original repository. To avoid having to hardcode a branch name or version number in the actions, the two steps are inlined instead.
a9a040e to
ab3cb28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a wrong description and a malfunctioning import of an action relative to the current path: GitHub Actions tries to load the file from the repository it was called from, not relative to the actions repository. To avoid hardcoding branch names or the repository name, I decided to inline the two setup steps into each action.
The gpg-sign action was also broken due to #1: the arguments weren't properly passed in when the loop was added. In addition, I moved the loop inside the container so that it doesn't have to be started for each file to be signed, but only once.