feat: add skipStartupWarnings flag to skip warnings on demand MONGOSH-2371 #2501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new skipStartupWarnings flag to let users suppress server startup warnings on demand.
- Extends CLI and TypeScript option interfaces with
skipStartupWarnings - Updates banner logic to omit
startupWarningswhen the flag is set - Registers the flag in the argument parser and adds a unit test for the new behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/cli-repl/src/mongosh-repl.ts | Added skipStartupWarnings option and updated banner logic to use it |
| packages/cli-repl/src/mongosh-repl.spec.ts | Added a test case to verify warnings are skipped when the flag is true |
| packages/cli-repl/src/arg-parser.ts | Registered skipStartupWarnings in the parser’s boolean options |
| packages/arg-parser/src/cli-options.ts | Extended the CliOptions interface with skipStartupWarnings |
Comments suppressed due to low confidence (2)
packages/cli-repl/src/mongosh-repl.spec.ts:1349
- Mock the 'automationNotices' and 'nonGenuineMongoDBCheck' commands in this test to prevent unexpected calls and ensure the test reliably covers only the suppression of 'startupWarnings'.
it('startup warnings are absent when skipStartupWarnings flag is present', async function () {
packages/cli-repl/src/arg-parser.ts:74
- [nitpick] Add a help description entry for the
--skipStartupWarningsflag so users see a clear explanation in the CLI's usage output.
'skipStartupWarnings',
Co-authored-by: Anna Henningsen <github@addaleax.net>
addaleax
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a flag (
skipStartupWarning) to skip the server's startup warnings