feat: initial feature-flagged, new autocompleter. Now lazy loaded on first use MONGOSH-2036 #2462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
May 29, 2025
addaleax
reviewed
May 30, 2025
| } | ||
|
|
||
| // mongodb-ts-autocomplete requires a connection and a schema | ||
| if (this.shellCliOptions.nodb) { |
There was a problem hiding this comment.
--nodb does not directly imply that db is inaccessible, e.g. you can do
$ mongosh --nodb
[...]
> db = connect(process.env.CLUSTER);to basically get the same behavior as mongosh $CLUSTER
There was a problem hiding this comment.
Do you have an idea of a better thing to check?
There was a problem hiding this comment.
You'd have to check what the methods on getAutocompletionContext() return (/whether they return), I'd say
There was a problem hiding this comment.
I removed the code from here. Will add it to mongodb-ts-autocomplete separately
There was a problem hiding this comment.
and added mongodb-js/devtools-shared#542
addaleax
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to now lazy loading mongodb-ts-autocomplete, I previously forgot that the tests won't run for the new one unless you specify USE_NEW_AUTOCOMPLETE=true.
I fixed the tests now, but it does highlight some subtle changes between the new design and the old. Notably with the typescript way we only autocomplete for collections that are known to exist, so we can't autocomplete
db.doesNotExistYet.insertOne(which is a valid use case for creating a new collection. In probably all other instances this new behaviour is arguably an improvement because if you typed out a collection name that does not exist then not getting autocomplete results is a powerful hint that you made a mistake.Furthermore the new autocomplete does not take into account server version or capabilities (yet), so things like getShardDistribution autocompletes for every collection and db.watch autocomplete for every database.
And finally mongodb-ts-autocomplete does not support connections that aren't connected. It expects objects like
dbto be real and to be able to list databases and collections and get collection schemas. We can probably tweak it in future so you can get a partial experience, but for now I'm not calling it in the noDb scenario. It is still feature flagged after all.