feat(shell-api): add Mongo bulkWrite API MONGOSH-1100 #2416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
previously approved these changes
Mar 25, 2025
| bulkWrite( | ||
| models: AnyClientBulkWriteModel<Document>[], | ||
| options: ClientBulkWriteOptions = {} | ||
| ): Promise<ClientBulkWriteResult> { |
There was a problem hiding this comment.
We've typically wrapped result types in our own types so that we're a bit more independent when it comes to server changes, see result.ts – I'd consider doing that here as well if we can (this mostly already matches our existing BulkWriteResult as well?)
packages/shell-api/src/mongo.ts
Outdated
| import type { LogEntry } from './log-entry'; | ||
| import { parseAnyLogEntry } from './log-entry'; | ||
| import type { ShellBson } from './shell-bson'; | ||
| import type { ClientBulkWriteOptions } from 'mongodb'; |
There was a problem hiding this comment.
No imports from mongodb in shell-api, the dependency on that package is only for use in the integration tests of shell-api
If you need driver types, they should be exported from service-provider-core. The fact that we're just re-exporting the driver types there is honestly not great, but it's just pretty practical for now
7376071 to
cd63fab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
bulkWrite(...)command for Mongo instances.As stated for the driver, this API is meant to replace the existing bulk write API on the Collection as it supports a bulk write across multiple databases and collections in a single call.
The command uses the active mongosh client and replicates the API from the driver in form of