feat: introduces drop-index tool for regular index #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Introduces a new drop-index tool for MongoDB that allows users to drop regular indexes from collections, categorized as a delete operation requiring user confirmation.
- Adds a new MongoDB tool for dropping indexes with proper validation and elicitation
- Implements comprehensive integration tests covering success and error scenarios
- Configures the tool to require user confirmation before execution
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tools/mongodb/delete/dropIndex.ts | New tool implementation for dropping MongoDB indexes |
| src/tools/mongodb/tools.ts | Registers the new DropIndexTool in the MongoDB tools array |
| src/common/config.ts | Adds drop-index to the list of tools requiring confirmation |
| tests/integration/tools/mongodb/delete/dropIndex.test.ts | Comprehensive integration tests for the drop-index functionality |
b3d669a to
e0a7780
Compare
📊 Accuracy Test Results📈 Summary
📊 Baseline Comparison
📎 Download Full HTML Report - Look for the Report generated on: 10/13/2025, 9:16:41 PM |
nirinchev
reviewed
Oct 13, 2025
| protected description = "Drop an index for the provided database and collection."; | ||
| protected argsShape = { | ||
| ...DbOperationArgs, | ||
| indexName: CommonArgs.string().nonempty().describe("The name of the index to be dropped."), |
There was a problem hiding this comment.
This doesn't seem right - index names can be unicode:
There was a problem hiding this comment.
Interesting. Just noticed that rest of the tools don't enforce these checks. I do wonder though how practical are such index names?
There was a problem hiding this comment.
Removed the unicode check
nirinchev
approved these changes
Oct 14, 2025
1. The tool has been marked to require user confirmation before execution. 2. Tests are added to confirm the negative and positive behaviour
2593cc0 to
a6ba8ff
Compare
Pull Request Test Coverage Report for Build 18492324576Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds a drop-index tool categorised under delete operation and marked as one requiring elicitation.
Checklist