feat/COMPASS-9504 add expand collapse toggle to the node title #152
Conversation
|
Ah, I had an implicit assumption that we'll be flipping the icon based on the state, but it's true that the designs don't mention this explicitly. Looking at other cases in Compass, we have this icon in the connections sidebar but there it's only doing a collapse all. We have a collapse/expand in the CRUD view and that one is flipping, but it's a single arrow. |
|
Can we also add this to the |
|
Yeah, I guess it's closer to the sidebar collapse button (and the icon is the same) so no flippage needed! 🙂
Sure, will do |
But that one is actually not a toggle, it only does collapse |
|
I mean the icon, there's no way to flip it, right? |
|
Updated the storybook story to support the new toggle |
External Links
Description
Adds a new toggle to the note title to allow for expand collapse all behavior
Notes for Reviewers
This doesn't include
isExpandedargument in the event callback that was mentioned in the tech design as there doesn't seem to be a reason to provide it: we will be controlling the expanded state from the consumer side, we can pass it down so that the diagram package can return it back to us, but this feels redundant and passing this value through the whole package is a lot of work, so I omitted it📸 Screenshots/Screencasts