feat/COMPASS-9696 Add actions prop to node, shown in the header #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianhhong
reviewed
Aug 21, 2025
| <Icon fill={theme.node.headerIcon} glyph="Drag" /> | ||
| </NodeHeaderIcon> | ||
| <NodeHeaderTitle>{title}</NodeHeaderTitle> | ||
| {actions} |
There was a problem hiding this comment.
Small suggestion, can we wrap this in a <div> with margin-left: 'auto' since the actions will always be hugging the right of the header?
There was a problem hiding this comment.
In case we want to add a badge next to the text I was thinking leaving that up to the consumer may give more flexibility. With that considered though actions might not be the best name, can't think of much better of one though.
There was a problem hiding this comment.
Merged it in, happy to change in a follow up pr if you'd like it that way! let me know.
lchans
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Links
Description
Adds an
actionsprop to the NodeProps interface. This will be used for showing the+icon for adding a field in Compass' data modeling.📸 Screenshots/Screencasts