fix(compass-indexes): fix missing banner in data explorer COMPASS-9947 #7451
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where a banner message about search indexes on views was not being displayed in Data Explorer for MongoDB versions 8.0+. The fix restructures the logic to properly handle both Compass and Data Explorer version compatibility checks.
- Refactored version compatibility check logic to handle Compass and Data Explorer separately
- Added style fix to remove text decoration from upgrade button
- Ensured proper banner display for views in both environments based on version requirements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| view-version-incompatible-banners.tsx | Added inline style to remove text decoration from upgrade button |
| indexes.tsx | Refactored banner logic to properly check version compatibility for both Compass and Data Explorer |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
"These indexes can be created and viewed under Search and Vector Search." should show in DE for views with version 8.0+. This was not being displayed because of an early incorrect return.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes