Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add initial GPU implementation of Non-Max Suppression (NMS) #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Morteza1814 wants to merge 3 commits into
base: main
Choose a base branch
Loading
from
Open

Add initial GPU implementation of Non-Max Suppression (NMS) #5600

Morteza1814 wants to merge 3 commits into from

Conversation

@Morteza1814
Copy link

@Morteza1814 Morteza1814 commented Nov 21, 2025

This PR introduces the first GPU-accelerated implementation of Non-Max Suppression (NMS) within the max/kernels/src/nn module. This implementation runs NMS per thread for each (batch, class) pair, matching the functional behavior of the CPU version. This version focuses on functional correctness and establishing the GPU execution framework. Performance optimizations will be added in follow-up PRs.

@Morteza1814 Morteza1814 requested a review from a team as a code owner November 21, 2025 01:48
@github-actions
Copy link

github-actions bot commented Nov 21, 2025 •
edited
Loading


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ (Morteza1814)[https://github.com/Morteza1814]
❌ @abduld
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@Morteza1814
Copy link
Author

Morteza1814 commented Nov 21, 2025

I have read the CLA Document and I hereby sign the CLA

@Morteza1814
Copy link
Author

Morteza1814 commented Nov 21, 2025

recheck

@JoeLoser JoeLoser requested a review from abduld November 21, 2025 03:33
@abduld
Copy link
Contributor

abduld commented Nov 24, 2025

!sync

@abduld
Copy link
Contributor

abduld commented Nov 24, 2025

!sync

modular-cla-bot bot added a commit to modular/cla that referenced this pull request Nov 24, 2025
@modular-cla-bot
@abduld has signed the CLA in modular/modular#5600
285504c
@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abduld abduld Awaiting requested review from abduld

At least 1 approving review is required to merge this pull request.

Assignees

@abduld abduld

Labels

imported-internally Signals that a given pull request has been imported internally.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Morteza1814 @abduld @modularbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.