Enhance MCPClient with connection timeout and file existence checks; …#88
Open
Borelli-7 wants to merge 4 commits intomodelcontextprotocol:mainmodelcontextprotocol/quickstart-resources:mainfrom
Open
Enhance MCPClient with connection timeout and file existence checks; …#88Borelli-7 wants to merge 4 commits intomodelcontextprotocol:mainmodelcontextprotocol/quickstart-resources:mainfrom
Borelli-7 wants to merge 4 commits intomodelcontextprotocol:mainmodelcontextprotocol/quickstart-resources:mainfrom
Conversation
| content: result.content as string, | ||
| }); | ||
| try { | ||
| console.log( |
There was a problem hiding this comment.
console.logs turned on by default seems like a security risk in production environments.
|
I'm not part of this project and can approve commits? Might need some stricter security :) |
Member
jonathanhefner
left a comment
There was a problem hiding this comment.
Thanks for the PR, but I'm unclear on the purpose of the proposed changes. Are the changes purely cosmetic?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update dependencies and refactor the codebase of mcp-client module
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context