Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: add _meta to more objects#963

Merged
ihrpr merged 1 commit intomainmodelcontextprotocol/python-sdk:mainfrom
fweinberger/meta-on-addtl-interfacesmodelcontextprotocol/python-sdk:fweinberger/meta-on-addtl-interfacesCopy head branch name to clipboard
Jun 16, 2025
Merged

feat: add _meta to more objects#963
ihrpr merged 1 commit intomainmodelcontextprotocol/python-sdk:mainfrom
fweinberger/meta-on-addtl-interfacesmodelcontextprotocol/python-sdk:fweinberger/meta-on-addtl-interfacesCopy head branch name to clipboard

Conversation

@felixweinberger
Copy link
Contributor

@felixweinberger felixweinberger commented Jun 16, 2025 •
edited
Loading

Motivation and Context

Add _meta fields to additional MCP types. This PR updates the Python SDK to align with the protocol changes from modelcontextprotocol/modelcontextprotocol#710, which added _meta fields to several additional types in the MCP specification.

  • Resource
  • ResourceTemplate
  • Tool
  • TextContent
  • ImageContent
  • AudioContent
  • Root

How Has This Been Tested?

uv run ruff check
uv run pytest

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

TypeScript equivalent modelcontextprotocol/typescript-sdk#630

@felixweinberger felixweinberger requested a review from ihrpr June 16, 2025 14:41
@ihrpr ihrpr linked an issue Jun 16, 2025 that may be closed by this pull request
feat: Adds _meta to additional interface types. #710 #958
Closed
ihrpr
ihrpr requested changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can we make sure that model_config is in the end?

src/mcp/types.py Outdated Show resolved Hide resolved
@felixweinberger felixweinberger force-pushed the fweinberger/meta-on-addtl-interfaces branch from fdcdfde to 620c866 Compare June 16, 2025 15:15
@felixweinberger
Copy link
Contributor Author

felixweinberger commented Jun 16, 2025

Added

ResourceContentsSchema
PromptSchema
EmbeddedResourceSchema

As well to match modelcontextprotocol/modelcontextprotocol#710

@felixweinberger felixweinberger requested a review from ihrpr June 16, 2025 15:17
ihrpr
ihrpr approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ihrpr ihrpr merged commit 1eb1bba into main Jun 16, 2025
12 checks passed
@ihrpr ihrpr deleted the fweinberger/meta-on-addtl-interfaces branch June 16, 2025 15:43
@medaminezghal medaminezghal mentioned this pull request Jul 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihrpr ihrpr ihrpr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Adds _meta to additional interface types. #710

2 participants

@felixweinberger @ihrpr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.