Fix simple-auth server example AuthorizationCode.redirect_uri type#948
Closed
basoko wants to merge 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
Closed
Fix simple-auth server example AuthorizationCode.redirect_uri type#948basoko wants to merge 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
basoko wants to merge 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
Conversation
The AuthorizationCode.redirect_uri field type is AnyUrl, but the example used AnyHttpUrl type. This mismatch causes the redirect URI check in TokenHandler to fail, since it compares against AuthorizationCodeRequest.redirect_uri, which also expects AnyUrl.
Member
|
this part of the example has been simplified now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AuthorizationCode.redirect_uri field type is AnyUrl, but the example used AnyHttpUrl type.
This mismatch causes the redirect URI check in TokenHandler to fail, since it compares against AuthorizationCodeRequest.redirect_uri, which also expects AnyUrl.
Motivation and Context
It makes the simple-auth server example to work with simple-auth client example. Without the change when client requests to get the token it fails with a "Bad Request" error.
How Has This Been Tested?
Manually by running server and client examples locally.
Breaking Changes
No.
Types of changes
Checklist
Additional context