Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

improve server logging#867

Merged
Kludex merged 3 commits intomainmodelcontextprotocol/python-sdk:mainfrom
server-loggingmodelcontextprotocol/python-sdk:server-loggingCopy head branch name to clipboard
Jun 2, 2025
Merged

improve server logging#867
Kludex merged 3 commits intomainmodelcontextprotocol/python-sdk:mainfrom
server-loggingmodelcontextprotocol/python-sdk:server-loggingCopy head branch name to clipboard

Conversation

@samuelcolvin
Copy link
Member

Motivation and Context

  1. server logging was used using logging parameters
  2. repeated dict lookups when checking for membership

How Has This Been Tested?

Tests should cover all cases.

Breaking Changes

No.

Types of changes

  • code improvement
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Kludex
Kludex previously approved these changes Jun 2, 2025
src/mcp/server/lowlevel/server.py Outdated Show resolved Hide resolved
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Kludex
Kludex previously approved these changes Jun 2, 2025
src/mcp/server/lowlevel/server.py Outdated Show resolved Hide resolved
@Kludex Kludex enabled auto-merge (squash) June 2, 2025 08:01
@Kludex Kludex merged commit 5441767 into main Jun 2, 2025
13 checks passed
@Kludex Kludex deleted the server-logging branch June 2, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.