RFC: Lower log levels used for connections#821
Merged
ihrpr merged 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom May 27, 2025
Merged
RFC: Lower log levels used for connections#821ihrpr merged 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
ihrpr merged 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
Conversation
ihrpr
approved these changes
May 27, 2025
Contributor
ihrpr
left a comment
There was a problem hiding this comment.
Thank you!
ugh, yeah, we need to implement proper URI sanitization, adding to the list. For now it's Okay to lower the level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not ideal, but currently some servers encode authorization in their URI. To reduce risk of such servers in other situations lower the log level of messages including the URI so we don't log potentially auth-containing data by default.
Motivation and Context
As above really, it could be done by altering log levels but it's unclear this granularity is needed so instead proposing changing it.
How Has This Been Tested?
Ran locally
Breaking Changes
No
Types of changes
Checklist
Additional context
N/A