Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Python lint: Ruff rule PLW1510 -- subprocess-run-without-check#794

Merged
ihrpr merged 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
cclauss:patch-1cclauss/python-sdk:patch-1Copy head branch name to clipboard
May 23, 2025
Merged

Python lint: Ruff rule PLW1510 -- subprocess-run-without-check#794
ihrpr merged 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
cclauss:patch-1cclauss/python-sdk:patch-1Copy head branch name to clipboard

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented May 23, 2025

A subset of:

% ruff check --select=PLW1510

 1	PLW1510	[*] subprocess-run-without-check

https://docs.astral.sh/ruff/rules/subprocess-run-without-check

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

A subset of:
*  modelcontextprotocol#525

% `ruff check --select=PLW1510`
```
 1	PLW1510	[*] subprocess-run-without-check
```
https://docs.astral.sh/ruff/rules/subprocess-run-without-check
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ihrpr ihrpr merged commit 073471c into modelcontextprotocol:main May 23, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.