Add OAuth authentication client for HTTPX #751
Merged
+2,483
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarleton
requested changes
May 19, 2025
examples/clients/simple-auth-client/mcp_simple_auth_client/main.py
Outdated
Show resolved
Hide resolved
examples/clients/simple-auth-client/mcp_simple_auth_client/main.py
Outdated
Show resolved
Hide resolved
pcarleton
previously approved these changes
May 19, 2025
|
@ihrpr Thank you very much for working on this request quickly! The OAuth implementation looks great and works well for our use case. With the Token Storage Provider in place, as long as the contract is maintained, we can also bypass the 3-legged OAuth flow and connect to MCP servers using an internally generated OAuth token - which is also perfect for us. |
This was referenced May 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Auth in client using HTTPX Custom authentication schemes
.
NOTE: This PR adds support for Streamable HTTP, but SSE will be added as a follow up, all we need to do is to add one parameter.
This PR Implements Auth in spec version 2025-03-26
Follow ups:
Related Issues:
#652
Related PRs:
#700
#308