Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Support Disabling SSL verification for testing #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Support Disabling SSL verification for testing #415

wants to merge 6 commits into from

Conversation

yfaney
Copy link

@yfaney yfaney commented Apr 2, 2025

This change will support an option to disable SSL verification for testing.

Motivation and Context

This change will support an option to disable SSL verification for testing.

How Has This Been Tested?

This change will support an option to disable SSL verification for testing.

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@yfaney yfaney marked this pull request as draft April 2, 2025 20:38
@yfaney yfaney marked this pull request as ready for review April 2, 2025 20:49
@yfaney yfaney changed the title Disabling SSL verification for testing Support Disabling SSL verification for testing Apr 3, 2025
@mikeedjones
Copy link

mikeedjones commented Apr 16, 2025 •
edited
Loading

Any reason why this or #505 can't be merged?

@ihrpr ihrpr added this to the r-05-25 milestone Apr 29, 2025
@mcp-shadow mcp-shadow bot mentioned this pull request May 13, 2025
Closed
5 tasks
@ihrpr
Copy link
Contributor

ihrpr commented May 23, 2025

Thank you for your contribution!

Closing this PR in favour of PR #752, which addresses the same use case plus many others. Users needing to disable SSL verification can:

  def create_no_ssl_client(**kwargs):
      return httpx.AsyncClient(verify=False, **kwargs)

  # Use with SSE client
  async with sse_client(url, httpx_client_factory=create_no_ssl_client) as streams:
      # ...

@ihrpr ihrpr closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r-05-25
Development

Successfully merging this pull request may close these issues.
3 participants
@yfaney @mikeedjones @ihrpr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.