Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

handle BrokenResourceError gracefully#237

Closed
lingster wants to merge 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
lingster:mainlingster/python-sdk:mainCopy head branch name to clipboard
Closed

handle BrokenResourceError gracefully#237
lingster wants to merge 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
lingster:mainlingster/python-sdk:mainCopy head branch name to clipboard

Conversation

@lingster
Copy link

@lingster lingster commented Mar 1, 2025

Improved Error handling when a BrokenResourceError occurs

Motivation and Context

With my mcp server, I occasionally get this error which renders my claude session unusable.

How Has This Been Tested?

Tested my mcp server with Claude Desktop

Breaking Changes

No breaking changes

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • [x ] I have read the MCP Documentation
  • [x ] My code follows the repository's style guidelines
  • [x ] New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the stream is rendered unusable as indicated by a BrokenResourceError, we should handle this appropriately. I don't think ignoring is the right appraoch. We likely want to close the connection at this point. Clients should graefully restart the process.

Copy link

@mcp-shadow mcp-shadow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to the MCP Python SDK!

Your PR addresses a valid issue with handling BrokenResourceError in the stdio transport. However, as there has been no activity on this PR for over 2 months, I'm closing it at this time.

We appreciate your effort in identifying and attempting to fix this issue. If you decide to refresh this PR with the suggested improvements, please feel free to reopen it or submit a new one.

@mcp-shadow mcp-shadow bot closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.