Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

test: validate README.md freeze guard (DO NOT MERGE)#2049

Closed
maxisbey wants to merge 2 commits intomainmodelcontextprotocol/python-sdk:mainfrom
test/readme-freeze-guardmodelcontextprotocol/python-sdk:test/readme-freeze-guardCopy head branch name to clipboard
Closed

test: validate README.md freeze guard (DO NOT MERGE)#2049
maxisbey wants to merge 2 commits intomainmodelcontextprotocol/python-sdk:mainfrom
test/readme-freeze-guardmodelcontextprotocol/python-sdk:test/readme-freeze-guardCopy head branch name to clipboard

Conversation

@maxisbey
Copy link
Contributor

This PR intentionally modifies README.md to verify that the CI guard from #2048 correctly catches and rejects it. Do not merge — close after CI runs.

The readme-v1-frozen pre-commit hook uses language: fail, which
unconditionally fails when its files pattern matches any file in the
candidate set. Since CI runs pre-commit with --all-files, README.md
always matches and the hook always fails, breaking CI on main and all
PRs.

Fix this with a two-part approach:

1. Skip the readme-v1-frozen hook in CI via the SKIP env var (the same
   mechanism already used for no-commit-to-branch). The hook continues
   to work locally where pre-commit only checks staged files.

2. Add a standalone CI step that uses git diff to check whether a PR
   actually modifies README.md. This provides CI-level enforcement
   that the pre-commit hook cannot offer in --all-files mode.
@maxisbey
Copy link
Contributor Author

maxisbey commented Feb 13, 2026

the failing CI shows this works (you can go to the Checks tab to see the failing CI even though I've closed the pr)

@maxisbey maxisbey closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.