fix: use ASGI callable for SSE endpoint to avoid BaseHTTPMiddleware AssertionError (#883)#2029
Draft
Ashutosh0x wants to merge 5 commits intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
Ashutosh0x:fix/883-sse-middleware-assertionAshutosh0x/python-sdk:fix/883-sse-middleware-assertionCopy head branch name to clipboard
Draft
fix: use ASGI callable for SSE endpoint to avoid BaseHTTPMiddleware AssertionError (#883)#2029Ashutosh0x wants to merge 5 commits intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom Ashutosh0x:fix/883-sse-middleware-assertionAshutosh0x/python-sdk:fix/883-sse-middleware-assertionCopy head branch name to clipboard
Ashutosh0x wants to merge 5 commits intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
Ashutosh0x:fix/883-sse-middleware-assertionAshutosh0x/python-sdk:fix/883-sse-middleware-assertionCopy head branch name to clipboard
Conversation
…ssertionError (modelcontextprotocol#883) When Starlette's BaseHTTPMiddleware wraps the SSE endpoint, it expects http.response.body messages. However, the SSE handler sends raw ASGI events, causing 'AssertionError: Unexpected message'. Fix: Replace the Starlette endpoint wrapper (sse_endpoint function) with a callable ASGI class (HandleSseAsgi) so the SSE handler bypasses middleware response body wrapping. Also remove the unnecessary 'return Response()' from handle_sse since it's a raw ASGI callable. Closes modelcontextprotocol#883
Closed
Contributor
|
Marking as draft until CI is fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Starlette's BaseHTTPMiddleware wraps the SSE endpoint, it expects http.response.body messages. However, the SSE handler sends raw ASGI events, causing 'AssertionError: Unexpected message'.
This PR fixes the issue by replacing the Starlette endpoint wrapper (sse_endpoint function) with a callable ASGI class (HandleSseAsgi). This ensures the SSE handler bypasses middleware response body wrapping, resolving the AssertionError.
Also removes the unnecessary 'return Response()' from handle_sse since it's a raw ASGI callable.
Closes #883