Fix OAuth scope selection using wrong parameter#1632
Closed
jlowin wants to merge 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
jlowin:fix/oauth-scope-selection-bugjlowin/mcp-python-sdk:fix/oauth-scope-selection-bugCopy head branch name to clipboard
Closed
Fix OAuth scope selection using wrong parameter#1632jlowin wants to merge 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom jlowin:fix/oauth-scope-selection-bugjlowin/mcp-python-sdk:fix/oauth-scope-selection-bugCopy head branch name to clipboard
jlowin wants to merge 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom
jlowin:fix/oauth-scope-selection-bugjlowin/mcp-python-sdk:fix/oauth-scope-selection-bugCopy head branch name to clipboard
Conversation
Contributor
Author
|
This has been addressed identically in #1631, closing in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #1586 where the OAuth scope selection strategy was incorrectly passing the resource metadata URL instead of the scope from the WWW-Authenticate header.
AFAICT this breaks all Python MCP clients that connect to servers with WWW headers because it treats the URL as a scope with highest priority.
The
get_client_metadata_scopes()function expects the first parameter to be the scope string extracted from the WWW-Authenticate header. However, in this case it was incorrectly passingwww_auth_resource_metadata_url(a URL) instead of callingextract_scope_from_www_auth(response)to get the actual scope value.Closes #1630