Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Use proper sync resolution in CI#1325

Closed
Kludex wants to merge 2 commits intomainmodelcontextprotocol/python-sdk:mainfrom
fix-pipelinemodelcontextprotocol/python-sdk:fix-pipelineCopy head branch name to clipboard
Closed

Use proper sync resolution in CI#1325
Kludex wants to merge 2 commits intomainmodelcontextprotocol/python-sdk:mainfrom
fix-pipelinemodelcontextprotocol/python-sdk:fix-pipelineCopy head branch name to clipboard

Conversation

@Kludex
Copy link
Member

@Kludex Kludex commented Aug 30, 2025

No description provided.

@Kludex Kludex requested review from a team and dsp-ant August 30, 2025 21:01
@Kludex
Copy link
Member Author

Kludex commented Aug 30, 2025

@maxisbey Do you have time to debug this?

@maxisbey
Copy link
Contributor

maxisbey commented Sep 1, 2025

@maxisbey Do you have time to debug this?

Pretty sure it's because of this function here:

def test_command_execution(mock_config_path: Path):

It runs a uv command built here:

uv_path = get_uv_path()

This is then run without uv --frozen and without whatever dependency resolution is being set by the changes you made in this PR. So the unit test times out since it's re-installing a bunch of dependencies due to the different dependency version resolution uv is using when launched inside the unit test.

@felixweinberger felixweinberger added the needs more work Not ready to be merged yet, needs additional follow-up from the author(s). label Sep 23, 2025
@felixweinberger
Copy link
Contributor

Will pick this up from @ihrpr

@felixweinberger felixweinberger added the needs maintainer action Potentially serious issue - needs proactive fix and maintainer attention label Sep 23, 2025
@felixweinberger felixweinberger self-assigned this Sep 23, 2025
@felixweinberger felixweinberger added this to the CI & Testing milestone Sep 30, 2025
@felixweinberger felixweinberger removed their assignment Oct 10, 2025
@felixweinberger
Copy link
Contributor

Closing in favor of #1507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs maintainer action Potentially serious issue - needs proactive fix and maintainer attention needs more work Not ready to be merged yet, needs additional follow-up from the author(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.