Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Jul 18, 2025

Motivation and Context

In the PR releasing a new revision of the spec (#783), commit e547813 changed a SHOULD to MUST in Lifecycle Operation section, but the change was not backported to the draft file.

This PR backports the change avoiding potential regressions.

How Has This Been Tested?

Ran instructions specified in CONTRIBUTING.md

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

None

@blkt blkt requested a review from a team July 18, 2025 09:12
In the PR releasing a new revision of the spec (modelcontextprotocol#783), commit e547813
changed a `SHOULD` to `MUST` in Lifecycle Operation section, but the
change was not backported to the draft file.

This PR backports the change avoiding potential regressions.
@blkt blkt force-pushed the fix/lifecycle-operation-potential-regression branch from 6e9a7e8 to cfa1a1a Compare July 18, 2025 09:19
Copy link
Member

@jonathanhefner jonathanhefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

docs/specification/draft/changelog.mdx Outdated Show resolved Hide resolved
Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

## Major changes

1. Enhance authorization server discovery with support for [OpenID Connect Discovery 1.0](https://openid.net/specs/openid-connect-discovery-1_0.html). (PR [#797](https://github.com/modelcontextprotocol/modelcontextprotocol/pull/797))
2. Backport change _SHOULD_ to _MUST_ in [Lifecycle Operation](/specification/draft/basic/lifecycle#operation) from commit [e547813](https://github.com/modelcontextprotocol/modelcontextprotocol/commit/e54781342c25d97c9ca4ba3fede237a2f3f37b32).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed. Draft is a draft, it's really a change per-se.

@dsp-ant dsp-ant merged commit e8703dc into modelcontextprotocol:main Jul 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.