fix: make CompleteRequest ref deserialization polymorphic#829
Open
bperhaps wants to merge 2 commits intomodelcontextprotocol:mainmodelcontextprotocol/java-sdk:mainfrom
Open
fix: make CompleteRequest ref deserialization polymorphic#829bperhaps wants to merge 2 commits intomodelcontextprotocol:mainmodelcontextprotocol/java-sdk:mainfrom
bperhaps wants to merge 2 commits intomodelcontextprotocol:mainmodelcontextprotocol/java-sdk:mainfrom
Conversation
8246a99 to
5aaf468
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To handle the ref (Prompt/Resource) of the Complete request reliably using Jackson polymorphic deserialization, we added type metadata (@JsonTypeInfo / @JsonSubTypes) to CompleteReference.
I also unified the server’s completion parameter parsing by replacing manual Map parsing with jsonMapper.convertValue(..., CompleteRequest.class).
Additionally, through request structure validation, cases where ref == null now fail explicitly.
Motivation and Context
While other McpSchemas specify JsonTypes, this one doesn't, leading to an error. While using this SDK, I discovered this.
I couldn't find a reason why CompleteReference was not being handled, so I'm posting a PR, deeming it an omission.
How Has This Been Tested?
i wrote some Unit test and do Integration test in local device
Breaking Changes
nop
Types of changes
Checklist
Additional context