Fix potential encoding issue in STDIO transport#825
Closed
xxxxxxjun wants to merge 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/java-sdk:mainfrom
xxxxxxjun:fix/stdio-encoding-inconsistencyxxxxxxjun/java-sdk:fix/stdio-encoding-inconsistencyCopy head branch name to clipboard
Closed
Fix potential encoding issue in STDIO transport#825xxxxxxjun wants to merge 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/java-sdk:mainfrom xxxxxxjun:fix/stdio-encoding-inconsistencyxxxxxxjun/java-sdk:fix/stdio-encoding-inconsistencyCopy head branch name to clipboard
xxxxxxjun wants to merge 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/java-sdk:mainfrom
xxxxxxjun:fix/stdio-encoding-inconsistencyxxxxxxjun/java-sdk:fix/stdio-encoding-inconsistencyCopy head branch name to clipboard
Conversation
Explicitly specify StandardCharsets.UTF_8 in InputStreamReader constructors for both server and client STDIO transports to ensure consistent encoding regardless of the JRE default charset. The MCP specification requires UTF-8 encoding for STDIO transport messages. The outbound processing already uses UTF_8 explicitly, but the inbound processing relied on the platform default charset, which could cause encoding mismatches on non-UTF-8 systems. Resolves modelcontextprotocol#295
e02c4a4 to
02999b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.