define explicitely that values should always be included in code completions#601
Merged
tzolov merged 2 commits intomodelcontextprotocol:mainmodelcontextprotocol/java-sdk:mainfrom Oct 6, 2025
sdelamo:codecompletionserializationsdelamo/java-sdk:codecompletionserializationCopy head branch name to clipboard
Merged
define explicitely that values should always be included in code completions#601tzolov merged 2 commits intomodelcontextprotocol:mainmodelcontextprotocol/java-sdk:mainfrom sdelamo:codecompletionserializationsdelamo/java-sdk:codecompletionserializationCopy head branch name to clipboard
tzolov merged 2 commits intomodelcontextprotocol:mainmodelcontextprotocol/java-sdk:mainfrom
sdelamo:codecompletionserializationsdelamo/java-sdk:codecompletionserializationCopy head branch name to clipboard
Conversation
tzolov
approved these changes
Oct 6, 2025
tzolov
pushed a commit
that referenced
this pull request
Oct 6, 2025
…letions (#601) * define explicitely that values should always be included * spring apply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
For empty responses in resource completions, I am seeing such errors if values are not included:
This PR adds explicitly the
@JsonInclude(JsonInclude.Include.ALWAYS)annotation and a test.How Has This Been Tested?
yes, a test is included
Breaking Changes
no.
Types of changes
Checklist