Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

fix: when using JsonTypeInfo.DEDUCTION don’t add include#587

Merged
tzolov merged 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/java-sdk:mainfrom
sdelamo:json-typesdelamo/java-sdk:json-typeCopy head branch name to clipboard
Sep 30, 2025
Merged

fix: when using JsonTypeInfo.DEDUCTION don’t add include#587
tzolov merged 1 commit intomodelcontextprotocol:mainmodelcontextprotocol/java-sdk:mainfrom
sdelamo:json-typesdelamo/java-sdk:json-typeCopy head branch name to clipboard

Conversation

@sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Sep 30, 2025

From the JSonTypeInfo Javadocs:

If deduction is being used annotation properties visible, property and include are ignored.

This is causing issues with serialization downstream.

From the JSonTypeInfo Javadocs:

> If deduction is being used annotation properties visible, property and include are ignored.

This is causing issues with serialization downstream.
Copy link
Contributor

@tzolov tzolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzolov tzolov merged commit 12292ab into modelcontextprotocol:main Sep 30, 2025
1 check passed
@tzolov tzolov added this to the 0.14.0 milestone Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.