Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d13420f

Browse filesBrowse files
committed
Removed empty optimize test//added check for x, y, z_edges all same length
1 parent 09d04f9 commit d13420f
Copy full SHA for d13420f

File tree

Expand file treeCollapse file tree

2 files changed

+4
-11
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-11
lines changed

‎plotly/tests/test_optional/test_figure_factory.py

Copy file name to clipboardExpand all lines: plotly/tests/test_optional/test_figure_factory.py
-11Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -753,17 +753,6 @@ def test_trisurf_all_args(self):
753753
self.assert_dict_equal(test_trisurf_plot['data'][1],
754754
exp_trisurf_plot['data'][1])
755755

756-
def test_optimize_trisurf(self):
757-
758-
# check that trisurf will give warnings if the plotting will take
759-
# a long time
760-
761-
pass
762-
763-
764-
765-
766-
767756

768757
class TestScatterPlotMatrix(NumpyTestUtilsMixin, TestCase):
769758

‎plotly/tools.py

Copy file name to clipboardExpand all lines: plotly/tools.py
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1589,6 +1589,10 @@ def _trisurf(x, y, z, simplices, colormap=None, dist_func=None,
15891589
y_edge = np.hstack([y_edge, y_edge_pull.reshape([1, -1])[0]])
15901590
z_edge = np.hstack([z_edge, z_edge_pull.reshape([1, -1])[0]])
15911591

1592+
if not (len(x_edge) == len(y_edge) == len(z_edge)):
1593+
raise exceptions.PlotlyError("The lengths of x_edge, y_edge and "
1594+
"z_edge are not the same.")
1595+
15921596
# define the lines for plotting
15931597
lines = graph_objs.Scatter3d(
15941598
x=x_edge, y=y_edge, z=z_edge, mode='lines',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.