contrib/rootless-setuptool: Fix iptables detection #49833
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a logical error in the rootless setup tool where the iptables error handling was incorrectly placed. The code was setting `faced_iptables_error=1` even when iptables was available, causing unnecessary error messages and setup suggestions. This patch correctly moves the error handling into the `else` branch so that we only report iptables errors when the command is actually unavailable. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
robmry
approved these changes
Apr 17, 2025
Contributor
robmry
left a comment
There was a problem hiding this comment.
Eek, thank you.
Looks like I lost the "else" when I applied one of the review suggestions ... https://github.com/moby/moby/compare/ad177b44c71733d1af3923dd1ccdfdb73408ca42..f80feba1810c6a57ba92ebc03753c384335b08f9
AkihiroSuda
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a logical error in the rootless setup tool where the iptables error handling was incorrectly placed. The code was setting
faced_iptables_error=1even when iptables was available, causing unnecessary error messages and setup suggestions.This patch correctly moves the error handling into the
elsebranch so that we only report iptables errors when the command is actually unavailable.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)