[17.03.x] Backport lazy unmount volume #33120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is an error unmounting a local volume, it is still possible to call `Remove()` on the volume causing removal of the mounted resources which is generally not desirable. This ensures that resources are unmounted before attempting removal. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit db3576f) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This is a spiritual backport of acbfe6b The afformentioned commit was not cherry-picked because it is a broader change to the codebase, whereas this is the same basic fix but localized to the local volume driver. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This was referenced May 9, 2017
|
All green except some networking hiccup on Windows in 1 test. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks db3576f
Then converts the local volume unmount to use a lazy unmount on Linux.
This is the equivalent of acbfe6b but localized to the local volume driver rather than affecting the entire codebase.
ping @mlaventure @thaJeztah