Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix endpoint mode loading from Compose file in stack deploy#32333

Merged
vdemeester merged 1 commit intomoby:mastermoby/moby:masterfrom
dnephin:fix-endpoint-modednephin/docker:fix-endpoint-modeCopy head branch name to clipboard
Apr 4, 2017
Merged

Fix endpoint mode loading from Compose file in stack deploy#32333
vdemeester merged 1 commit intomoby:mastermoby/moby:masterfrom
dnephin:fix-endpoint-modednephin/docker:fix-endpoint-modeCopy head branch name to clipboard

Conversation

@dnephin
Copy link
Copy Markdown
Member

@dnephin dnephin commented Apr 3, 2017

Fixes #32325

Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin dnephin force-pushed the fix-endpoint-mode branch from 20c6187 to 25f0086 Compare April 3, 2017 21:51
@vieux
Copy link
Copy Markdown
Contributor

vieux commented Apr 4, 2017

LGTM

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Apr 4, 2017

@dnephin will go in 17.05

@dnephin dnephin modified the milestones: 17.05.0, 17.04.0 Apr 4, 2017
Copy link
Copy Markdown
Contributor

@boaz0 boaz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vdemeester vdemeester self-assigned this Apr 4, 2017
@vdemeester vdemeester self-requested a review April 4, 2017 08:26
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

@thaJeztah
Copy link
Copy Markdown
Member

relates to #31795

@vdemeester vdemeester merged commit 93ffbb7 into moby:master Apr 4, 2017
@dnephin dnephin deleted the fix-endpoint-mode branch April 4, 2017 14:39
dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
Fix endpoint mode loading from Compose file in stack deploy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.